Add SCID types to ChannelDetails
#444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the previously-omitted `short_channel_id`, `inbound_scid_alias`, `outbound_scid_alias` types to `ChannelDetails`.
tnull
force-pushed
the
2025-01-add-scid
branch
from
1db481b to
8a6f4e7
Compare
|
Kicked CI. |
arik-so
approved these changes
Jan 27, 2025
| /// counterparty will recognize the alias provided here in place of the [`short_channel_id`] | ||
| /// when they see a payment to be routed to us. | ||
| /// | ||
| /// Our counterparty may choose to rotate this value at any time, though will always recognize |
There was a problem hiding this comment.
nit: "though will" reads like it's missing a subject
There was a problem hiding this comment.
It isn’t though? Btw, kinda preexisting as I stole the docs from LDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419.
We add the previously-omitted
short_channel_id,inbound_scid_alias,outbound_scid_aliastypes toChannelDetails.